Swtich RequestMailer to deliver mail in the background #8351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract deliveries into helper method which stores and clear the mail queue. This gives us one place to update to perform delayed mail delivery via ActiveJob.
Deliver emails in the background job instead of doing it inline.
gbp
force-pushed
the
request-mailer-deliver-later
branch
from
61de041
to
df14c1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Connected to https://github.com/mysociety/whatdotheyknow-private/issues/315
What does this do?
deliver_laterto deliver mail in the background.Why was this needed?
I thought this was going to be needed for the above issue but in retrospect this has been achievable by a theme patch. This is still a good improvement though.
Have you updated the changelog? If this is not necessary, put square brackets around this: skip changelog