Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2366] Remove broken Google Chart #8462

Merged
merged 1 commit into from
Nov 22, 2024
Merged

[#2366] Remove broken Google Chart #8462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions app/views/request_game/play.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,12 @@

<div id="game_sidebar" class="game_sidebar">
<p style="text-align: center">
<%= image_tag "https://chart.googleapis.com/chart?chs=250x125&cht=gom&chd=t:#{@percentage}",
:size => "250x125",
:alt => "A chart showing #{@percentage}% of requests have been categorised",
:title => "#{@percentage}% of requests have been categorised" %>
<br><%= n_("{{number_of_requests}} request left to categorise / {{total_number_of_requests}} total",
"{{number_of_requests}} requests left to categorise / {{total_number_of_requests}} total",
@missing,
:number_of_requests => number_with_delimiter(@missing),
:total_number_of_requests => number_with_delimiter(@total)) %>
<br />
<%= n_('{{number_of_requests}} request left to categorise / {{total_number_of_requests}} total',
'{{number_of_requests}} requests left to categorise / {{total_number_of_requests}} total',
@missing,
number_of_requests: number_with_delimiter(@missing),
total_number_of_requests: number_with_delimiter(@total)) %>
</p>

<h2><%= _("Top recent players") %></h2>
Expand Down
1 change: 1 addition & 0 deletions doc/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

## Highlighted Features

* Remove deprecated Google Chart from request game (Gareth Rees)
* Migrated from Stripe Plans to Stripe Prices (Graeme Porteous)
* Change notes so that records tagged with `name:value` will be associated with
notes tagged as `name` (Graeme Porteous)
Expand Down
Loading