Fixes issue with not being able to order dropdowns in extra questions #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3566 +/- ##
==========================================
- Coverage 84.91% 82.59% -2.33%
==========================================
Files 292 343 +51
Lines 18838 23205 +4367
Branches 3532 3543 +11
==========================================
+ Hits 15997 19167 +3170
- Misses 1721 2922 +1201
+ Partials 1120 1116 -4
Continue to review full report at Codecov.
|
dracos
requested changes
Aug 13, 2021
mysociety-pusher
force-pushed
the
2511-question-dropdown-ordering
branch
from
0275a97 to
e536dd0
Compare
dracos
requested changes
Aug 17, 2021
Raised by Peterborough but an FMS issue as, when creating dropdowns for extra questions on categories, the dropdown options are sorted on index number, but this has not been a numeric sort so looks random to the user. The order of dropdown items now remains in the order they are in the creation/editing screen. Adds a regression test. mysociety/societyworks#2511
mysociety-pusher
force-pushed
the
2511-question-dropdown-ordering
branch
from
e536dd0 to
6ccfa71
Compare
dracos
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ordering of dropdown list options is now sorted numerically on the index position. This means the order will be that expected by the user when creating the options.
https://github.com/mysociety/societyworks/issues/2511