Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bristol] Convert Bristol to a Multi #378

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MorayMySoc
Copy link
Contributor

@MorayMySoc MorayMySoc commented Jan 8, 2025

Bristol has a passthrough which needs to continue
to work alongside the new Alloy integration.

https://github.com/mysociety/societyworks/issues/4683

Bristol has a passthrough which needs to continue
to work alongsider the new Alloy integration.

mysociety/societyworks#4683
@MorayMySoc MorayMySoc requested a review from chrismytton January 8, 2025 10:22
Copy link
Member

@chrismytton chrismytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Couple of very minor comments.

around BUILDARGS => sub {
my ($orig, $class, %args) = @_;
$args{jurisdiction_id} = 'www.bristol.gov.uk';
$args{batch_service} = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this is needed for Bristol. This is for councils (think it's just Merton) that process Open311 requests async and return a token that can later be exchanged for the newly created service request ID.


=head1 SYNOPSIS

Bristol manage their own Confirm integration but have a managed Alloy integration, so is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it might be clearer to simply state that Bristol have their own Open311 server, rather than specifically mentioning Confirm. What they do behind their Open311 endpoint might change at some point, but that doesn't matter to us.

@MorayMySoc MorayMySoc requested a review from chrismytton January 8, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants