Avoid Pin by using a trait object suffix for Request #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
reviewed
Aug 25, 2020
| where | ||
| R: ?Sized + private::Response, | ||
| { | ||
| marker: PhantomData<&'a ()>, |
There was a problem hiding this comment.
I was worried about this not being invariant, but... &mut Request<'a> is invariant over 'a because of the &mut, as it's basically a &mut (TypeId, Option<&'a T>) for some unknown T, so it has to be invariant to avoid allowing writing in a shorter lifetime.
eddyb
reviewed
Aug 25, 2020
src/lib.rs
Outdated
| _marker: PhantomData, | ||
| }, | ||
| value: None, | ||
| impl<T: 'static> Request<'_, Option<T>> { |
There was a problem hiding this comment.
I wonder if you'd maybe want to make this Request<'static, Option<T>>?
|
So I came up with a way to write |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the callsites significantly, as the parameter type is now a simpler
&mut Request<'a>type, and reduces the amount of unsafe code which is necessary.