This repository was archived by the owner on Jan 13, 2025. It is now read-only.
Conversation
…suspending lambdas
…mplify matching code
0ffc688 to
3a00398
Compare
ChristopherKoellner
left a comment
There was a problem hiding this comment.
I have one question.
Other than that it looks good.
org.jacoco.core/src/org/jacoco/core/internal/analysis/filter/AbstractMatcher.java
Show resolved
Hide resolved
ChristopherKoellner
approved these changes
Nov 22, 2021
ChristopherKoellner
approved these changes
Dec 18, 2022
Release 0.8.11
36ed729 to
7acfe7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the following class:
the Kotlin 1.6.0 compiler generates an inner class
SuspendingLambda.$bar.$1with a functioninvokeSuspendwith the following bytecode:The
tableswitchinstruction creates two branches, one of which (instructions 36 to 45) is impossible to cover in test cases, because the Kotlin compiler already takes care that this fault condition doesn't happen.In this PR, a new filter is introduced to filter both the
tableswitchinstruction and the branch that throws theIllegalStateException.Also, new functions
nextIsLdcandnextIsLdcStartingWithare introduced to theAbstractMatcherto simplify a few cases where thecstproperty of theLdcInsnNodeis checked against a String or a String prefix.