Implement system test #336

amaya382 · 2016-09-07T09:21:35Z

related with #323

Usage and example are written in systemtest/README.md, please refer to it

resolved conflict pom.xml

coveralls · 2016-09-07T10:13:43Z

Coverage decreased (-1.007%) to 33.853% when pulling 242dfaf on amaya382:feature/systemtest into df4f4dd on myui:master.

coveralls · 2016-09-07T10:19:58Z

Coverage decreased (-0.7%) to 34.162% when pulling 242dfaf on amaya382:feature/systemtest into df4f4dd on myui:master.

coveralls · 2016-09-08T09:20:22Z

Coverage decreased (-1.002%) to 33.858% when pulling 48a4fc9 on amaya382:feature/systemtest into df4f4dd on myui:master.

coveralls · 2016-09-08T09:30:14Z

Coverage decreased (-1.007%) to 33.853% when pulling 48a4fc9 on amaya382:feature/systemtest into df4f4dd on myui:master.

coveralls · 2016-09-08T09:42:46Z

Coverage decreased (-1.002%) to 33.858% when pulling 48a4fc9 on amaya382:feature/systemtest into df4f4dd on myui:master.

coveralls · 2016-09-08T09:42:46Z

Coverage decreased (-0.7%) to 34.157% when pulling 48a4fc9 on amaya382:feature/systemtest into df4f4dd on myui:master.

coveralls · 2016-09-08T09:51:03Z

Coverage decreased (-1.002%) to 33.858% when pulling 48a4fc9 on amaya382:feature/systemtest into df4f4dd on myui:master.

coveralls · 2016-09-12T06:59:25Z

Coverage decreased (-0.8%) to 34.067% when pulling 0b01896 on amaya382:feature/systemtest into df4f4dd on myui:master.

coveralls · 2016-09-12T06:59:25Z

Coverage decreased (-1.1%) to 33.764% when pulling 0b01896 on amaya382:feature/systemtest into df4f4dd on myui:master.

coveralls · 2016-09-13T07:59:31Z

Coverage decreased (-1.09%) to 33.766% when pulling d2f0370 on amaya382:feature/systemtest into df4f4dd on myui:master.

Lewuathe

@amaya382 So sorry for late reviewing. The system test module example almost passed except for test3 case. And I added some comments. Could you check these comments again? After passing test3, it's ready to be merged, I think.

In addition could you update the license header as described here. Please refer HIVEMALL-12.
Thanks!

Lewuathe · 2016-11-12T12:17:15Z

systemtest/README.md

+    public void test4() throws Exception {
+        // test on HiveRunner once only
+        predictor.expect(Throwable.class); // you can use systemtest w/ other rules 
+        team.set(HQ.fromStatement("invalid queryyy")); // this query throws an exception


It shows Cannot resolve method. We need to pass dummy expected argument here.

Lewuathe · 2016-11-12T12:18:08Z

systemtest/README.md

+    public void test3() throws Exception {
+        // test on HiveRunner once only
+        // auto matching by files which name is `test3` in `case/` and `answer/`
+        team.set(HQ.autoMatchingByFileName("test3", ci)); // unordered test


It should be

team.set(HQ.autoMatchingByFileName("test3"), ci);

Lewuathe · 2016-11-12T12:18:59Z

systemtest/README.md

+
+The above requires following files
+
+* `systemtest/src/test/resources/hivemall/HogeTest/init/color.tsv` (`systemtest/src/test/resources/${path/to/package}/${className}/init/${fileName}`)


It might be better to rename HogeTest to QuickExample here.

Lewuathe · 2016-11-12T12:19:11Z

systemtest/README.md

+pink	255	192	203
+```
+
+* `systemtest/src/test/resources/hivemall/HogeTest/case/test3` (`systemtest/src/test/resources/${path/to/package}/${className}/case/${fileName}`)


ditto: HogeTest

Lewuathe · 2016-11-12T12:20:14Z

systemtest/README.md

+```sql
+-- write your hive queries
+-- comments like this and multiple queries in one row are allowed
+SELECT blue FROM color WHERE name = 'lavender';SELECT green FROM color WHERE name LIKE 'orange%' 


We have to add semicolon (;) at the end of line, otherwise interpreted as 2 queries.

Lewuathe · 2016-11-12T12:36:30Z

systemtest/src/main/java/hivemall/systemtest/runner/SystemTestRunner.java

+        }
+    }
+
+    //// execute RawHQ


minor: Could you align comment format? Especially the number of /s.

Lewuathe · 2016-11-12T12:38:36Z

systemtest/src/main/java/hivemall/systemtest/runner/SystemTestRunner.java

+
+        if (ordered) {
+            // take order into consideration (like list)
+            Assert.assertThat(Arrays.asList(answer.split(IO.RD)),


Assert.assertThat requires actual as first argument. So please put result in first argument.

Lewuathe · 2016-11-12T12:40:14Z

systemtest/src/main/java/hivemall/systemtest/runner/SystemTestRunner.java

+        } else {
+            // not take order into consideration (like multiset)
+            Assert.assertThat(Arrays.asList(answer.split(IO.RD)),
+                Matchers.containsInAnyOrder(result.toArray()));


When I ran QuickExample#test3 described README, I faced below error.

java.lang.AssertionError: Expected: iterable over ["165", "69"] in any order but: Not matched: "165 69" at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.junit.Assert.assertThat(Assert.java:956) at org.junit.Assert.assertThat(Assert.java:923) at hivemall.systemtest.runner.SystemTestRunner.matching(SystemTestRunner.java:202) at hivemall.systemtest.runner.SystemTestTeam.run(SystemTestTeam.java:180) at hivemall.QuickExample.test3(QuickExample.java:100)

Could you check this matching is working as expected?

@Lewuathe I cannot reproduce it. plz check that answer/test3 uses tab characters as delimiter, since several space characters have got mixed in README(will be fixed)

Sorry I seemed to have mistake to copy answer/test3. I confirmed it works as expected. Thanks.

Lewuathe · 2016-11-12T12:56:29Z

systemtest/src/main/java/hivemall/systemtest/runner/TDSystemTestRunner.java

+            fileUploadCommitRetryLimit = Integer.valueOf(props.getProperty("fileUploadCommitRetryLimit"));
+        }
+
+        final Properties TDPorps = System.getProperties();


s/TDPorps/TDProps/ ?

Lewuathe · 2016-11-12T12:57:36Z

systemtest/src/main/java/hivemall/systemtest/runner/TDSystemTestRunner.java

+        }
+        System.setProperties(TDPorps);
+
+        client = System.getProperties().size() == TDPorps.size() ? TDClient.newClient() // use $HOME/.td/td.conf


Is System.getProperties().size() == TDPorps.size() check meaningful?
TDPorps is already set as system property in L.94. So the size is always same.

amaya382 · 2016-11-13T23:28:03Z

@Lewuathe okay, I'll check them in about a week

coveralls · 2016-11-16T07:05:48Z

Changes Unknown when pulling 62e3588 on amaya382:feature/systemtest into * on myui:master*.

coveralls · 2016-11-16T07:05:48Z

Changes Unknown when pulling 62e3588 on amaya382:feature/systemtest into * on myui:master*.

myui · 2016-11-16T09:02:19Z

@amaya382 https://github.com/myui/hivemall/blob/master/bin/format_header.sh is a tool to run header formatting. FYI

coveralls · 2016-11-17T19:47:53Z

Coverage decreased (-1.1%) to 33.742% when pulling f2ae1f7 on amaya382:feature/systemtest into ee244c3 on myui:master.

coveralls · 2016-11-17T19:47:53Z

Coverage decreased (-1.1%) to 33.742% when pulling f2ae1f7 on amaya382:feature/systemtest into ee244c3 on myui:master.

coveralls · 2016-11-17T19:56:30Z

Coverage decreased (-1.1%) to 33.742% when pulling f2ae1f7 on amaya382:feature/systemtest into ee244c3 on myui:master.

Lewuathe

@amaya382 Thank you so much for updating!
Though I added a trivial comment, it LGTM! 👍

Lewuathe · 2016-11-19T04:16:09Z

systemtest/src/main/java/hivemall/systemtest/runner/SystemTestRunner.java

@@ -175,7 +180,7 @@ public final boolean isImmutableTable(final String tableName) {
        }
    }

-    ////// execute UploadFileHQ
+    // >>>execute UploadFileHQ


trivial: >> instead of >>>?

@Lewuathe > intends to mean hierarchical structure of argument

Lewuathe · 2016-11-21T10:40:45Z

@myui Could you check it? If it's okay please merge it.

myui · 2016-11-21T11:07:11Z

Sure. Will do after #385 is being merged.

myui · 2016-12-02T08:16:10Z

@amaya382 moved to apache/incubator-hivemall#5

amaya382 added 12 commits September 5, 2016 18:34

add feature for testing UDF

2237215

add usage

4d2bdfc

move systemtest into specific package

6e31bbd

mod project settings of systemtest

d0108a9

add ordered/unordered result matching

1a0da21

add license header

81efb8c

enable to use external properties

6bc276c

update README about external properties

915cf78

suppress warnings

bd0143c

potential bug to exception

57566e4

add ordered/unordered result matching for multiple queries

02a9385

refine README

bca5404

myui added pullrequest under-review labels Sep 7, 2016

myui added this to the v0.4 milestone Sep 7, 2016

myui self-assigned this Sep 7, 2016

Merge branch 'master' into 'feature/systemtest'

242dfaf

resolved conflict pom.xml

amaya382 force-pushed the feature/systemtest branch from c22ae80 to 242dfaf Compare September 7, 2016 09:46

Lewuathe mentioned this pull request Sep 8, 2016

Unit test for learning UDTFs #228

Closed

amaya382 force-pushed the feature/systemtest branch 2 times, most recently from 048a4cf to aa5388b Compare September 8, 2016 08:46

refine README

48a4fc9

amaya382 force-pushed the feature/systemtest branch from aa5388b to 48a4fc9 Compare September 8, 2016 08:48

amaya382 added 2 commits September 13, 2016 16:03

refresh null check

b5f35c3

mod name and inheritance structure

d2f0370

Lewuathe reviewed Nov 12, 2016

View reviewed changes

Update license headers

62e3588

amaya382 added 8 commits November 17, 2016 14:15

Mod README

1e8093b

Add exception

f40ade0

Make dir name static

635a0a1

Mod assert methods

06c88de

Fix process of tdprop

4aa1cfc

Mod README

bdf38c2

Refine access modifiers/calls

25db0c0

Update license header

f2ae1f7

Lewuathe approved these changes Nov 19, 2016

View reviewed changes

Lewuathe mentioned this pull request Dec 2, 2016

Implement system test apache/incubator-hivemall#2

Closed

myui mentioned this pull request Dec 2, 2016

[WIP] Implement System Test apache/incubator-hivemall#5

Closed

myui closed this Dec 2, 2016

myui mentioned this pull request Dec 6, 2016

[WIP] Implement System Test apache/incubator-hivemall#12

Open


		The above requires following files

		* `systemtest/src/test/resources/hivemall/HogeTest/init/color.tsv` (`systemtest/src/test/resources/${path/to/package}/${className}/init/${fileName}`)

Implement system test #336

Implement system test #336

Conversation

amaya382 commented Sep 7, 2016

coveralls commented Sep 7, 2016

coveralls commented Sep 7, 2016 • edited Loading

coveralls commented Sep 8, 2016 • edited Loading

coveralls commented Sep 8, 2016 • edited Loading

coveralls commented Sep 8, 2016 • edited Loading

coveralls commented Sep 8, 2016

coveralls commented Sep 8, 2016 • edited Loading

coveralls commented Sep 12, 2016

coveralls commented Sep 12, 2016 • edited Loading

coveralls commented Sep 13, 2016 • edited Loading

Lewuathe left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amaya382 commented Nov 13, 2016

coveralls commented Nov 16, 2016

coveralls commented Nov 16, 2016 • edited Loading

myui commented Nov 16, 2016

coveralls commented Nov 17, 2016

coveralls commented Nov 17, 2016

coveralls commented Nov 17, 2016 • edited Loading

Lewuathe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Lewuathe commented Nov 21, 2016

myui commented Nov 21, 2016 • edited Loading

myui commented Dec 2, 2016

coveralls commented Sep 7, 2016 •

edited

Loading

coveralls commented Sep 8, 2016 •

edited

Loading

coveralls commented Sep 8, 2016 •

edited

Loading

coveralls commented Sep 8, 2016 •

edited

Loading

coveralls commented Sep 8, 2016 •

edited

Loading

coveralls commented Sep 12, 2016 •

edited

Loading

coveralls commented Sep 13, 2016 •

edited

Loading

Lewuathe left a comment •

edited

Loading

coveralls commented Nov 16, 2016 •

edited

Loading

coveralls commented Nov 17, 2016 •

edited

Loading

myui commented Nov 21, 2016 •

edited

Loading