Efficiency improvements #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 27, 2022 15:28
Previously we were pre-calculating all task costs on machines and then accessing through calculated_runtime. When running with large files, this was ridiculously wasteful and would cause SHADOW to hang. Now it can process an example skaworkflow (>4400 tasks) on a HPC environment (~900 machines) in ~1minute. FCFS was also incorrect, so we fixed that up.
Previously we would generate slots for all allocs, rather than excluding allocations that finish before the earliest possible start time of current task. Now we only consider the necessary allocations, rather than all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR features a number of changes that improves the performance of the scheduling, specifically in the context of:
There is also the addition of multiprocessing examples for use with large graphs, which were the originator of efficiency investigations.