[#84] config 기반 실행 구현 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: not null and default
myyrakle
commented
Jun 20, 2024
| )] | ||
| pub host: String, | ||
| #[clap(name = "config", long, help = "config file path")] | ||
| pub config: Option<String>, |
There was a problem hiding this comment.
config 파일을 넘겨서 실행하는 형태로 정리
There was a problem hiding this comment.
없으면 OS별 기본 config 경로를 사용
| pub const DEFAULT_CONFIG_BASEPATH: &str = "C:\\Program Files\\rrdb"; | ||
|
|
||
| // #[cfg(target_os = "macos")] | ||
| // TODO: MacOS 경로 추가 |
There was a problem hiding this comment.
그리고 별도 디렉터리가 필요한 사이즈는 아니라서 정리 차원에서 파일로 내림
| @@ -11,7 +11,7 @@ impl Executor { | |||
| pub async fn get_table_config(&self, table_name: TableName) -> Result<TableConfig, RRDBError> { | |||
| let encoder = StorageEncoder::new(); | |||
|
|
|||
| let base_path = self.get_base_path(); | |||
| let base_path = self.get_data_directory(); | |||
There was a problem hiding this comment.
이젠 전반적으로 data directory를 직접 가져와서 거기다 저장하는 형태로 변경
(data directory는 설정하기에 따라서 유동적으로 변경할 수 있어야 함)
| @@ -13,12 +16,14 @@ use tokio::sync::mpsc; | |||
| use super::client::ClientInfo; | |||
|
|
|||
| pub struct Server { | |||
| pub option: ServerOption, | |||
| pub config: Arc<GlobalConfig>, | |||
| } | |||
There was a problem hiding this comment.
설정 정보들은 서버가 들고 있다가 executor에게 전달해줘야함 (data directory 등의 정보를 전달하기 위함)
wHoIsDReAmer
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #84
설명
일부 기능 구현 및 개선, 리팩토링