Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add model aliases #7

Merged
merged 1 commit into from
Mar 27, 2019
Merged

Add model aliases #7

merged 1 commit into from
Mar 27, 2019

Conversation

mzdrale
Copy link
Owner

@mzdrale mzdrale commented Mar 27, 2019 •
edited
Loading

Some Ubee routers can use multiple names. For example, model EVW3200-Wifi is reported as EVW320B, so I added alias.

@mzdrale mzdrale requested a review from StevenLooman March 27, 2019 17:16
@mzdrale
Copy link
Owner Author

mzdrale commented Mar 27, 2019

@StevenLooman , I added support for model aliases, as you suggested. I've tested it and it's working for me. Can you please take a look and test when you get a chance? Thanks.

@mzdrale mzdrale self-assigned this Mar 27, 2019
@mzdrale mzdrale added the enhancement New feature or request label Mar 27, 2019
@StevenLooman
Copy link
Contributor

Works like a charm!

StevenLooman
StevenLooman reviewed Mar 27, 2019
View reviewed changes
Copy link
Contributor

@StevenLooman StevenLooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, merge it!

@mzdrale mzdrale merged commit 8caec15 into master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenLooman StevenLooman StevenLooman left review comments

Assignees

@mzdrale mzdrale

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzdrale @StevenLooman