Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] mined echoes remain on screen #18

Closed
mzdun opened this issue Oct 7, 2024 · 0 comments · Fixed by #19
Closed

[BUG] mined echoes remain on screen #18

mzdun opened this issue Oct 7, 2024 · 0 comments · Fixed by #19
Labels
bug Something isn't working

Comments

@mzdun
Copy link
Owner

mzdun commented Oct 7, 2024

Describe the bug
When a block is mined within echo's timeline, the echo remains on-screen.

To Reproduce
Steps to reproduce the behavior:

  1. Set the echo timeline to something reasonable, e.g. 10 minutes
  2. Scan for anything close
  3. Mine a highlighted block.
  4. See echo still on screen

Expected behavior
The echo would disapear closer to the mining action, that to end of lifetime.
@mzdun mzdun added the bug Something isn't working label Oct 7, 2024
mzdun added a commit that referenced this issue Oct 7, 2024
@mzdun
fix: mined echoes remain on screen
f14b3c7 
Fixes: #18
@mzdun mzdun mentioned this issue Oct 7, 2024
Merged
mzdun added a commit that referenced this issue Oct 7, 2024
@mzdun
fix: mined echoes remain on screen
7e2611f 
Fixes: #18
@mzdun mzdun closed this as completed in #19 Oct 7, 2024
mzdun added a commit that referenced this issue Oct 7, 2024
@mzdun
chore: release 0.4.0
95bb258 
New Features:

 - color echoes based on `c:ores` subclasses (1688382)
 - add ARGB32 color to each block (1920f08)
 - drop maximum in favor of lifetime of echoes (50cda36)
 - add echoes lifetime (2626d87)
 - attach sonar drawing to the mod (ce72ea5)
 - draw echoes even if no shimmers are present (919de95)
 - get the sound sample from Amane:OG (4f9f0bc)
 - add activation sound event (3cc1d91)
 - attach sonar animation to the mod (4ace428)
 - animate the shimmers and echoes (37310e0)
 - introduce animation subsystem (4ae3f26)

Bug Fixes:

 - mined echoes remain on screen (7e2611f), fixes #18
 - use better name for slice pacer (ad1e442)
 - docs: update the README.md with scan screenshots (fa7dfe4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: mined echoes remain on screen mzdun/resource-scanner-mc
1 participant
@mzdun