Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] NullPointerException when a scanner is active and world disappears #21

Closed
mzdun opened this issue Oct 7, 2024 · 0 comments · Fixed by #25
Closed

[BUG] NullPointerException when a scanner is active and world disappears #21

mzdun opened this issue Oct 7, 2024 · 0 comments · Fixed by #25
Labels
bug Something isn't working needs triage

Comments

@mzdun
Copy link
Owner

mzdun commented Oct 7, 2024

Describe the bug
Game crashes, when exiting while scanner is active.

To Reproduce
Steps to reproduce the behavior:

  1. Enter a world
  2. Setup scanner so it goes for a long time (e.g. maximum depth)
  3. Press "Save and exit" (alt: close the window) while the shimmers are visible
  4. See error

Expected behavior
The scan either cancels smoothly or its run is otherwise irrelevant

Desktop (please complete the following information):

  • OS: Win11
  • Launcher: Feather
  • Version 0.4.0
@mzdun mzdun added bug Something isn't working needs triage labels Oct 7, 2024
mzdun added a commit that referenced this issue Oct 7, 2024
@mzdun
fix: crash during active scan with no more world
54ab9b6 
fixes: #21
@mzdun mzdun mentioned this issue Oct 7, 2024
Merged
@mzdun mzdun closed this as completed in #25 Oct 7, 2024
@mzdun mzdun closed this as completed in 39e3be0 Oct 7, 2024
mzdun added a commit that referenced this issue Oct 7, 2024
@mzdun
chore: release 0.4.1
910588e 
Bug Fixes:

 - crash during active scan with no more world (39e3be0), fixes #21
 - only one setting at a time is saved (24ac468), fixes #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: crash during active scan with no more world mzdun/resource-scanner-mc
1 participant
@mzdun