You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
iroh::blobs::Client::download returns a DownloadProgress which needs to be awaited, too, if you want to wait for the download to finish.
So node.blobs().download(hash, ...).await? is not enough to wait for a download to finish.
You also need node.blobs().download(hash, ...).await?.await? (or alternatively call .finish().await? on the DownloadProgress).
This should be documented in the .download function's docs.
I also suggested renaming .download to .start_download, but that seemed like a more controversial change.
The text was updated successfully, but these errors were encountered:
iroh::blobs::Client::download
returns aDownloadProgress
which needs to be awaited, too, if you want to wait for the download to finish.So
node.blobs().download(hash, ...).await?
is not enough to wait for a download to finish.You also need
node.blobs().download(hash, ...).await?.await?
(or alternatively call.finish().await?
on theDownloadProgress
).This should be documented in the
.download
function's docs.I also suggested renaming
.download
to.start_download
, but that seemed like a more controversial change.The text was updated successfully, but these errors were encountered: