Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Pin nextest version #44

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ci: Pin nextest version #44

wants to merge 1 commit into from

Conversation

matheus23
Copy link
Contributor

Description

Nextest seems to have some issues with file descriptors in the latest version. This pins nextest to a 3 month old version so we get reliable flaky test runs again.

Breaking Changes

Notes & open questions

Related PR: n0-computer/iroh#3088

Change checklist

  • Self-review.
  • [ ] Documentation updates following the style guide, if relevant.
  • [ ] Tests if relevant.
  • [ ] All breaking changes documented.

@matheus23 matheus23 self-assigned this Jan 3, 2025
@matheus23 matheus23 requested a review from rklaehn January 3, 2025 16:31
Copy link

github-actions bot commented Jan 3, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/44/docs/iroh_blobs/

Last updated: 2025-01-03T16:33:58Z

@flub
Copy link
Contributor

flub commented Jan 3, 2025

I was going to wait until this is shown to work, it only seems to affect flaky tests for now? (Which I have no explanation for whatsoever!) Or is it affecting all tests in this repo?

@matheus23
Copy link
Contributor Author

Maybe I'm jumping the gun here. Let's wait it out first then. We don't have to merge these yet.

@matheus23 matheus23 marked this pull request as draft January 3, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

2 participants