Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: switch to serde_error directly #5

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

dignifiedquire
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Oct 25, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/5/docs/iroh_blobs/

Last updated: 2024-10-25T13:47:54Z

Copy link
Collaborator

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dignifiedquire dignifiedquire merged commit f87c3bf into main Oct 28, 2024
23 of 24 checks passed
@dignifiedquire dignifiedquire deleted the refactor-serde-error branch October 28, 2024 13:29
github-merge-queue bot pushed a commit to n0-computer/iroh that referenced this pull request Oct 28, 2024
Directly uses `serde_error::Error` instead

Depends on n0-computer/iroh-blobs#5

## Breaking Changes

- removed
  - `iroh_base::rpc::RpcError`
  - `iroh_base::rpc::RpcResult`


Closes #2839
matheus23 pushed a commit to n0-computer/iroh that referenced this pull request Nov 14, 2024
Directly uses `serde_error::Error` instead

Depends on n0-computer/iroh-blobs#5

## Breaking Changes

- removed
  - `iroh_base::rpc::RpcError`
  - `iroh_base::rpc::RpcResult`


Closes #2839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants