-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Richer tags api #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh-blobs/pr/69/docs/iroh_blobs/ Last updated: 2025-03-12T13:55:03Z |
would be nice to have some tests, to make sure the basics of this work |
todo: make it compile and add tests
Yeah, this is why this is a draft. But you like the API? |
Added some tests |
great to see this 💪 |
dignifiedquire
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes the anemic tags api much more rich
Breaking Changes
Breaks the RPC protocol and the store trait
RPC protocol:
Store trait:
Notes & open questions
Question: should we enable the rpc feature flag by default? Given that the only way to get the pleasant API at this time is the rpc, and we want beginners to have a good experience? In my big refactor you will be able to get this API without rpc enabled, but for now this is just how it is.
Implements #65
Change checklist