refactor: use external protocols & update to iroh@0.29 #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
refactor-external-protocols
branch
from
48d4b3a to
ddf1e2d
Compare
rklaehn
reviewed
Nov 21, 2024
|
FYI bumped versions for manylinux which should resolve the current CI issues. As per https://github.com/pypa/manylinux manylinux_2014 should be very close to EoL even though it's still supported by the project. |
4 tasks
dignifiedquire
changed the title
niklaswimmer
reviewed
Dec 3, 2024
dignifiedquire
force-pushed
the
refactor-external-protocols
branch
from
1df5224 to
7fd2974
Compare
dignifiedquire
changed the title
ramfox
reviewed
Dec 4, 2024
Comment on lines
+87
to
+90
| let gossip = self | ||
| .router | ||
| .get_protocol(iroh_gossip::net::GOSSIP_ALPN) | ||
| .expect("no gossip available"); |
There was a problem hiding this comment.
Just calling out that we are removing get_protocol in the next release.
There was a problem hiding this comment.
...i guess this actually doesn't matter since we are removing the protocols in ffi next release anyway.
ramfox
approved these changes
Dec 4, 2024
Comment on lines
+87
to
+90
| let gossip = self | ||
| .router | ||
| .get_protocol(iroh_gossip::net::GOSSIP_ALPN) | ||
| .expect("no gossip available"); |
There was a problem hiding this comment.
...i guess this actually doesn't matter since we are removing the protocols in ffi next release anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uniffi
irohiroh-gossipiroh-docsiroh-blobsjs
irohiroh-gossipiroh-docsiroh-blobs