Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: make sure external contributors can get green CI #1297

Closed
Arqu opened this issue Jul 24, 2023 · 0 comments · Fixed by #1304 or #1327
Closed

ci: make sure external contributors can get green CI #1297

Arqu opened this issue Jul 24, 2023 · 0 comments · Fixed by #1304 or #1327
Assignees
@Arqu
Labels
ci continous integration
Milestone
v0.7.0

Comments

@Arqu
Copy link
Collaborator

Arqu commented Jul 24, 2023

The main issue here is that GH secrets are not shared with forks. This just strips the possibility to upload netsim reports to our infra, which I think is fine for external PRs.

Simply detecting forks and dropping report uploads should work.
@Arqu Arqu added the ci continous integration label Jul 24, 2023
@Arqu Arqu added this to the v0.6.0 milestone Jul 24, 2023
@Arqu Arqu self-assigned this Jul 24, 2023
@Arqu Arqu added this to iroh Jul 24, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog - unassigned issues in iroh Jul 24, 2023
@Arqu Arqu removed the status in iroh Jul 24, 2023
@Arqu Arqu moved this to 🔖 Ready - assigned issues in iroh Jul 24, 2023
@divagant-martian divagant-martian mentioned this issue Jul 24, 2023
Closed
4 tasks
@Arqu Arqu mentioned this issue Jul 27, 2023
Merged
3 tasks
@github-project-automation github-project-automation bot moved this from 🔖 Ready - assigned issues to ✅ Done in iroh Jul 27, 2023
@divagant-martian divagant-martian mentioned this issue Aug 2, 2023
Closed
3 tasks
@github-project-automation github-project-automation bot moved this from ✅ Done to 📋 Backlog - unassigned issues in iroh Aug 2, 2023
@Arqu Arqu moved this from 📋 Backlog - unassigned issues to 🔖 Ready - assigned issues in iroh Aug 2, 2023
@Arqu Arqu mentioned this issue Aug 3, 2023
Merged
3 tasks
@Arqu Arqu moved this from 🔖 Ready - assigned issues to 🏗 In progress in iroh Aug 3, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Arqu Arqu

Labels
ci continous integration
Projects
iroh
Archived in project
Milestone
v0.7.0
2 participants
@Arqu @divagant-martian