fix(iroh-net): portmapper priority follows described priority strategy #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
commented
Aug 2, 2023
dignifiedquire
approved these changes
Aug 2, 2023
|
it seems to be #1297 is not fixed |
|
closing to move to internal branch |
auto-merge was automatically disabled
August 2, 2023 18:09
Pull request was closed
|
@Arqu can you check, I thought you fixed this? |
|
moved to #1324 |
Ugh this makes no sense at all. Anyways, picking it up again tomorrow. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed that under current configuration options portmapping would always try pcp no matter what. This fixes the logic to first try available protocols and then attempt unavailable but enabled ones
Notes & open questions
further work will be required in the future anyway
Change checklist