fix tests in iroh sync and some cleanups #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
approved these changes
Jul 27, 2023
| cb(InsertOrigin::Local, signed_entry.clone()); | ||
| } | ||
| } | ||
|
|
||
| /// Hashes the given data and inserts it. |
There was a problem hiding this comment.
Maybe make clear in the comment that the data is not stored/inserted anyhwere, only its hash. Also, maybe return the hash.
dignifiedquire
force-pushed
the
sync-update-tests
branch
from
4b95261
to
23b8972
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.