Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pkarr relay with DNS server #2167

Merged
merged 7 commits into from
Apr 11, 2024
Merged

feat: pkarr relay with DNS server #2167

merged 7 commits into from
Apr 11, 2024

Conversation

Frando
Copy link
Member

@Frando Frando commented Apr 10, 2024

Description

Imports https://github.com/n0-computer/iroh-dns-server into this repo.

See n0-computer/iroh-dns-server#5 for previous review/discussion.

Now includes an integration smoke test in iroh-dns-server/src/lib.rs.

Notes & open questions

I think I addressed most review points that came up in the initial review. Prominently still open is:

  • The redb store is used from async context but only exposes a sync interface (redb default). I think this is fine for medium load. However for better performance we should reuse transactions, which likely means we need an actor on a separate thread, as we do in iroh-bytes and iroh-sync.

Change checklist

  • Self-review.
  • Documentation updates if relevant.
  • Tests if relevant.

@Frando Frando force-pushed the feat/dns-server branch 2 times, most recently from da3630d to 55c35d7 Compare April 10, 2024 13:05
@dignifiedquire dignifiedquire added this to the v0.14.0 milestone Apr 10, 2024
@rklaehn
Copy link
Contributor

rklaehn commented Apr 11, 2024

The redb store is used from async context but only exposes a sync interface (redb default). I think this is fine for medium load. However for better performance we should reuse transactions, which likely means we need an actor on a separate thread, as we do in iroh-bytes and iroh-sync.

Let's add the batching asap, since I am currently finding out that adding it to a big code base like iroh-sync is no fun at all.

But it does not have to happen in this PR.

Copy link
Contributor

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just adds the iroh-dns-server to the iroh repo.

It has been relatively thoroughly reviewed in n0-computer/iroh-dns-server#5

So I think we should just merge this and do small adjustments in subsequent PRs.

@rklaehn rklaehn merged commit e6f56d3 into feat/dns Apr 11, 2024
19 checks passed
@rklaehn rklaehn deleted the feat/dns-server branch April 11, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants