refactor(iroh-cli)!: Use config and logging from iroh-node-utils #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # Cargo.toml # iroh-cli/Cargo.toml # iroh/Cargo.toml # iroh/src/client.rs # iroh/src/client/docs.rs # iroh/src/node/rpc.rs # iroh/src/rpc_protocol.rs
# Conflicts: # Cargo.lock # iroh/src/node/rpc.rs
and move the node and net proto, client and server there
# Conflicts: # Cargo.lock
fix feature flags
and in some places where it does not.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2953/docs/iroh/ Last updated: 2024-11-20T11:15:10Z |
dignifiedquire
approved these changes
Nov 20, 2024
# Conflicts: # Cargo.lock # iroh-node-util/Cargo.toml # iroh-node-util/README.md # iroh-node-util/src/lib.rs # iroh/Cargo.toml
Arqu
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move things like figuring out the configuration and data directory into iroh-node-utils as well, so it can be used from other binaries than iroh-cli. E.g. doctor, or a pure blobs bin, or for testing.
Breaking Changes
This affects iroh-cli, which is a bin crate. But nevertheless, here are the changes:
Notes & open questions
Change checklist