Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): try to reuse msys2 dep #2956

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix(ci): try to reuse msys2 dep #2956

merged 1 commit into from
Nov 21, 2024

Conversation

Arqu
Copy link
Collaborator

@Arqu Arqu commented Nov 21, 2024

Description

According to https://github.com/msys2/setup-msys2?tab=readme-ov-file#release this should try to reuse an existing msys2 installation (though seems to reference a default fallback to the one installed on the GH hosted runners, unsure if it works for self hosted)

Edit: seems to be working

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@Arqu Arqu self-assigned this Nov 21, 2024
@Arqu Arqu added the ci continous integration label Nov 21, 2024
Copy link

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/2956/docs/iroh/

Last updated: 2024-11-21T18:55:06Z

@Arqu Arqu marked this pull request as ready for review November 21, 2024 18:58
Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: c077702

Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems appropriate according to the docs

@divagant-martian divagant-martian added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 4e58b1f Nov 21, 2024
29 of 53 checks passed
@Arqu Arqu deleted the arqu/msys branch November 21, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci continous integration
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants