Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update ipld in iroh-car to limit prost duplicates #307

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

fabricedesre
Copy link
Contributor

Before:

iroh (main)> cargo tree -i -p prost
error: There are multiple `prost` packages in your project, and the specification `prost` is ambiguous.
Please re-run this command with `-p <spec>` where `<spec>` is one of the following:
  prost@0.9.0
  prost@0.10.4
  prost@0.11.0

After:

iroh (main)> cargo tree -i -p prost
error: There are multiple `prost` packages in your project, and the specification `prost` is ambiguous.
Please re-run this command with `-p <spec>` where `<spec>` is one of the following:
  prost@0.10.4
  prost@0.11.0

I'm trying to get rid of the last dupe in ipld/libipld#152 but windows CI gets in the way...

@fabricedesre
Copy link
Contributor Author

I wonder why this was not done in f54eb73

@b5 b5 requested review from dignifiedquire and Arqu October 8, 2022 18:26
@b5
Copy link
Member

b5 commented Oct 10, 2022

@Arqu mind taking a look? I have a hard time seeing how this would be a problem

Copy link
Contributor

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if ci is happy

@Arqu Arqu merged commit ee43bd7 into n0-computer:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants