CLI and API starting point #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is still wrong, but at least tests a command we want to implement
Silence some clippy warnings
dignifiedquire
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI and API as proposed only has a few commands, and the original CLI and API had a lot more. In this PR I've stripped out all parts of the API and CLI we're not using yet, to have a clean starting point.
I have changed the
no-metricsflag to themetricsoption, as discussed in n0-computer/beetle#156The individual commands don't conform to the proposed new designs yet. I also haven't implemented any
startorstopcommand. But before I make more changes, this is a good point to do a PR, as it's still simple to review what's going on.The CLI test that exercises a fixture has been changed to be
iroh p2p lookupas well, though it doesn't yet define the correct answer.This fixes n0-computer/beetle#170
It implements n0-computer/beetle#182 too, though by just following what Clap does by default anyway (see the comment about the
iroh-ctlname we get back though)