feat: range request support #330
Conversation
iroh-resolver/src/unixfs.rs
Outdated
| } | ||
|
|
||
| fn poll_complete(self: Pin<&mut Self>, _cx: &mut Context<'_>) -> Poll<std::io::Result<u64>> { | ||
| Poll::Ready(Ok(0)) |
There was a problem hiding this comment.
Same as above, would love some input on what it should be. I'm assuming the delta from the initial position which in a simplified version returns the seek offset?
There was a problem hiding this comment.
Yes, I think this is the delta, so we need to store it and return it. Later when we do seeking with loading, this will also delegate to an internal future.
There was a problem hiding this comment.
So I took some time to understand this and as far as I get it it's not the delta but rather the final position it seeked to. Because otherwise the consumer would need to figure out what the delta means especially in circular buffer and negative moves etc.
There was a problem hiding this comment.
Yes new offset from the start is what should be returned 👍
Arqu
force-pushed
the
arqu/gw_spec_parity
branch
from
0d5a3ee
to
19692f6
Compare
|
@dignifiedquire can you take another look at the unixfs seeking, it's funkier now. |
| } | ||
| } | ||
|
|
||
| #[tokio::test] |
There was a problem hiding this comment.
Either in this PR or at least have an issue for seeking across dag-cbor, dag-json and raw files as well please.
There was a problem hiding this comment.
There was a problem hiding this comment.
Gotta do other stuff before release :/
|
merge conflict 😅 |
Closes n0-computer/beetle#234