Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iroh-gateway): add FileType::Raw option #332

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

ramfox
Copy link
Contributor

@ramfox ramfox commented Oct 12, 2022

also reverts previous commit that made a bad assumption about allowing Raw as a UnixfsType in the resolver

@ramfox ramfox requested a review from Arqu October 12, 2022 22:18
@ramfox ramfox marked this pull request as ready for review October 13, 2022 02:17
@ramfox ramfox self-assigned this Oct 13, 2022
@ramfox ramfox added the fix Fixes a bug label Oct 13, 2022
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that single bit.

&req.content_path,
req.download,
);
add_content_type_headers(&mut headers, &name);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing add_ipfs_roots_headers(&mut headers, metadata);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually ignore this, this will be covered in my PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

damn, github only showed me the first comment and not the second so I already pushed the change

Arqu
Arqu previously approved these changes Oct 13, 2022
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

also reverts previous commit that made a bad assumption about allowing `Raw` as a `UnixfsType` in the resolver
@ramfox ramfox force-pushed the ramfox/gateway_raw_block_fix branch from b15eb3d to 833bbdf Compare October 13, 2022 13:49
@ramfox ramfox requested a review from Arqu October 13, 2022 14:42
@ramfox ramfox added this to the v0.1.0 milestone Oct 13, 2022
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go go go

@ramfox ramfox merged commit ff4ef02 into main Oct 13, 2022
@ramfox ramfox deleted the ramfox/gateway_raw_block_fix branch October 13, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants