Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Bitwap Implementation #357

Merged
merged 283 commits into from
Oct 18, 2022
Merged

New Bitwap Implementation #357

merged 283 commits into from
Oct 18, 2022

Conversation

dignifiedquire
Copy link
Contributor

@dignifiedquire dignifiedquire commented Oct 17, 2022

Full port of go-bitswap...

Closes n0-computer/beetle#164

@dignifiedquire dignifiedquire marked this pull request as ready for review October 17, 2022 17:36
b5
b5 previously approved these changes Oct 17, 2022
b5
b5 previously approved these changes Oct 17, 2022
Arqu
Arqu previously approved these changes Oct 17, 2022
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean lgtm, left some nitpicks.

iroh-p2p/Cargo.toml Outdated Show resolved Hide resolved
max_conns_pending_out: 256,
max_conns_pending_in: 256,
max_conns_in: 256,
max_conns_out: 256,
max_conns_out: 512,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want these as the defaults?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, for now


metrics_handle.shutdown();
Ok(())
}

fn main() -> Result<()> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get rid if this and revert to the usual.

iroh-p2p/src/swarm.rs Outdated Show resolved Hide resolved
@dignifiedquire dignifiedquire dismissed stale reviews from Arqu and b5 via 24d2023 October 18, 2022 12:44
@dignifiedquire dignifiedquire merged commit 3cafdde into main Oct 18, 2022
@dignifiedquire dignifiedquire deleted the bitswap2 branch February 20, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

refactor bitswap to preserve connectivity with kubo nodes running go-bitswap
3 participants