-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Bitwap Implementation #357
Conversation
- do not redial on conn limit - buffer messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean lgtm, left some nitpicks.
max_conns_pending_out: 256, | ||
max_conns_pending_in: 256, | ||
max_conns_in: 256, | ||
max_conns_out: 256, | ||
max_conns_out: 512, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want these as the defaults?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, for now
iroh-p2p/src/main.rs
Outdated
|
||
metrics_handle.shutdown(); | ||
Ok(()) | ||
} | ||
|
||
fn main() -> Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should get rid if this and revert to the usual.
Full port of go-bitswap...
Closes n0-computer/beetle#164