Skip to content

Conversation

@Frando
Copy link
Member

@Frando Frando commented Nov 11, 2025

Description

Commented out tests on feat-multipath that are failing reliably. A couple more are failing sometimes with a panic in quinn at connection.rs:1164 which flub is trying to fix.

These tests are disabled on this PR:

failing tests:

  • magicsock::endpoint_map::tests::test_prune_direct_addresses
  • magicsock::endpoint_map::tests::test_prune_inactive
  • endpoint::connection::tests::test_0rtt_after_server_restart

hanging tests:

  • endpoint::tests::endpoint_two_direct_add_relay
  • magicsock::tests::test_two_devices_setup_teardown

partially failing tests

  • endpoint::tests::metrics_smoke (has metrics commented out)

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@Frando Frando marked this pull request as ready for review November 11, 2025 12:18
@github-actions
Copy link

github-actions bot commented Nov 11, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3646/docs/iroh/

Last updated: 2025-11-11T13:52:20Z

@n0bot n0bot bot added this to iroh Nov 11, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Nov 11, 2025
@flub
Copy link
Contributor

flub commented Nov 11, 2025

hanging tests:

* [ ]  `endpoint::tests::endpoint_two_direct_add_relay`

Huh, this one i actually care about. that should not hang or fail

@github-actions
Copy link

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 1890318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏗 In progress

Development

Successfully merging this pull request may close these issues.

3 participants