refactor(iroh): make some types more private and others more public #3774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3774/docs/iroh/ Last updated: 2025-12-15T21:09:31Z |
flub
approved these changes
Dec 15, 2025
Contributor
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
We should probably add the #[warn(unnamable_types)] to the lib.rs file now to keep think to this level?
ramfox
force-pushed
the
ramfox/unnameable-types
branch
from
1c99152 to
feeaa1d
Compare
ramfox
force-pushed
the
ramfox/quic-types
branch
from
476f40c to
433db37
Compare
ramfox
force-pushed
the
ramfox/unnameable-types
branch
from
feeaa1d to
74bba3f
Compare
added 5 commits
December 15, 2025 16:06
also removes unused `IpPort` struct
ramfox
force-pushed
the
ramfox/unnameable-types
branch
from
74bba3f to
1a4e253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds on the work done in #3757 to make types more or less public.
CreateHandleErrorpublicIncomingFuturepublicnet_report::GetRelayAddrErrorandnet_report::MeasureHttpsLatencyErrormore privateIpPortsstruct