Skip to content

Conversation

@rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Dec 15, 2025

Description

Adapt to changes made to iroh-quinn in n0-computer/quinn#257

Breaking Changes

endpoint::RecvStream::read_chunk: ordering: bool removed.

To read unordered chunks, you now have to create an UnorderedRecvStream. read_chunk on RecvStream is always ordered.

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.
    • List all breaking changes in the above "Breaking Changes" section.
    • Open an issue or PR on any number0 repos that are affected by this breaking change. Give guidance on how the updates should be handled or do the actual updates themselves. The major ones are:

@rklaehn rklaehn changed the base branch from main to feat-multipath December 15, 2025 16:52
@rklaehn rklaehn requested a review from flub December 15, 2025 16:52
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3776/docs/iroh/

Last updated: 2025-12-15T17:58:18Z

@flub
Copy link
Contributor

flub commented Dec 15, 2025

Breaking Changes

endpoint::RecvStream::read_chunk: ordering: bool removed

Please explain how to do this instead to make writing the release notes a bit easier.

I think we also need this type to be nameable, so it needs to be re-exported by iroh::endpoint. Which will create a conflict with #3757.

@n0bot n0bot bot added this to iroh Dec 15, 2025
@github-project-automation github-project-automation bot moved this to 🏗 In progress in iroh Dec 15, 2025
@rklaehn rklaehn marked this pull request as ready for review December 15, 2025 17:53
@dignifiedquire dignifiedquire merged commit 952b50e into feat-multipath Dec 15, 2025
21 of 28 checks passed
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in iroh Dec 15, 2025
@dignifiedquire
Copy link
Contributor

merged this for now to unblock things, @ramfox please take a look when you rebase/merge to include this in your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants