perf: Use the libipld built in way to scrape references #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
commented
Oct 21, 2022
| @@ -1400,18 +1400,16 @@ impl<T: ContentLoader> Resolver<T> { | |||
| /// Extract links from the given content. | |||
| pub fn parse_links(cid: &Cid, bytes: &[u8]) -> Result<Vec<Cid>> { | |||
| let codec = Codec::try_from(cid.codec()).context("unknown codec")?; | |||
| let mut cids = BTreeSet::new(); | |||
There was a problem hiding this comment.
You might argue that a hashset would be faster here, and you would not be wrong. I guess it is my determinism fetish...
|
Note that with this I am not entirely convinced that sending the cids over the RPC is worth it. The store can scrape the links. Unless we foresee a scenario where you would want to send different links than the block contains, but that would be weird... |
rklaehn
force-pushed
the
rklaehn/faster-link-scraping
branch
from
e2ce2d2
to
f84da6e
Compare
...without having to create an AST. Should be much faster.
rklaehn
force-pushed
the
rklaehn/faster-link-scraping
branch
from
f84da6e
to
d57b12a
Compare
|
Oh well, another error. Made an issue for this since it is unrelated to this: n0-computer/beetle#124 |
dignifiedquire
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...without having to create an AST. Should be much faster.
This has been working all the time for dag-cbor since we needed that at actyx, but I have also made the dag-pb case a bit faster in ipld/libipld#155