feat: provide only root, and only at the end of add #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are still waiting for the add to complete
rklaehn
force-pushed
the
rklaehn/separate-provide
branch
from
eb40e69
to
e0f2598
Compare
rklaehn
force-pushed
the
rklaehn/separate-provide
branch
from
b8dd65e
to
8d33ddb
Compare
rklaehn
force-pushed
the
rklaehn/separate-provide
branch
from
8d33ddb
to
9abcfaa
Compare
|
Added progress for the DHT update. And it is really easy to switch from "provide just root" to "provide all" |
b5
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
I've hijacked this PR to add a few important additional things:
- Add now requires p2p service is running. We need to get p2p load-on-start is for and for root CIDs only with this change. An early check confirms the service is up before proceeding.
- That check warns the user with the specific service that's missing & a hint to run
iroh start $SERVICE - I've added an
--allflag to iroh start, based on issues asmir was having with running quick benchmarks, and p2p not being part of the default set of services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are still waiting for the start_provide of the root to complete