Cleanup of store code #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rklaehn
force-pushed
the
rklaehn/local-gb
branch
2 times, most recently
from
5de9722
to
ce95bd3
Compare
LocalStore is completely synchronous and and not Send. In it we can store column family handles etc. It is the most convenient place to actually do stuff.
Basically we only have await on create, and where we need it for impl RpcStore.
rklaehn
force-pushed
the
rklaehn/local-gb
branch
from
ce95bd3
to
61efc9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This separates the store code into a LocalStore where all the things happen, that can properly store column family handles etc. and a Store that is just a forwarder for which RpcStore is implemented.
I think this is much nicer. We might want to use spawn_local at the async -> synchronous boundary though.
This is based on #412 , so once that is merged the diff would get smaller.