B5/output cleanup #427
Merged
B5/output cleanup #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also thought it was important to get a shoutout to @mxinden in the help text 😄
|
b5
commented
Oct 26, 2022
Comment on lines
+176
to
+182
| Peer ID - the identifier of the peer | ||
| Agent Version - software identifier similar to a web browser's user agent | ||
| Protocol Version - broad identifier for the peer & it's network | ||
| Observed Addresses - the peer's best guess at it's own public address(es) | ||
| based on feedback from other peers | ||
| Listening Addresses - address this peer is listening for connections on | ||
| Protocols - identifiers for protocols this peer speaks |
There was a problem hiding this comment.
feel free to weigh in on these definitions. I do wish there was a section outlining these on the libp2p docs
There was a problem hiding this comment.
@b5 I would say the best we have is https://github.com/libp2p/specs/tree/master/identify#the-identify-message
dignifiedquire
previously approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor cleanups, better documentation of the lookup command.
closes n0-computer/beetle#115