Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default start all services, but accept config #433

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

b5
Copy link
Member

@b5 b5 commented Oct 27, 2022

this PR changes the default for iroh start back to {gateway,store,p2p}, but now iroh CLI reads a new cli.config.toml file that accepts a single configuration parameter. We can use this to get back the "only gateway & store" behaviour with an installer script that makes cli.config.toml.

# when running on a laptop, only turn on the gateway & store by default
start_default_services = [
  "gateway",
  "store",
]

I've kept iroh start --all, because it's still useful to have a CLI flag that overrides what's started in any case

@b5 b5 added this to the v0.1.0 milestone Oct 27, 2022
@b5 b5 requested a review from Arqu October 27, 2022 21:17
@b5 b5 self-assigned this Oct 27, 2022
Copy link
Collaborator

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally, works like a charm.

@b5 b5 merged commit 227ea0b into main Oct 27, 2022
@b5 b5 deleted the b5/default_start_all_but_accept_config branch October 27, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants