refactor: exact instances of some Option/Result/other combinators #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huitseeker
force-pushed
the
warts
branch
2 times, most recently
from
d1b925e
to
a92387b
Compare
|
Thanks for the PR, could you explain the reasoning behind this? |
|
@dignifiedquire the intentional commit of this PR is the first, the other one being a standard run of clippy auto-fixes. The idea is to simplify the code from verbose pattern-matches to idiomatic standard library combinators they are an exact reimplementation of. My opinions on this are loosely held - if you're not convinced of those idioms being simpler, in part or as a group, I'm happy to amend the PR to your desires, or close it altogether. |
matthiasbeyer
suggested changes
Nov 11, 2022
huitseeker
force-pushed
the
warts
branch
2 times, most recently
from
0db3267
to
10fbc4e
Compare
|
Thanks for the review @matthiasbeyer! This makes total sense, I'll also amend the tooling with your comments! |
dignifiedquire
previously approved these changes
Nov 11, 2022
b5
reviewed
Nov 14, 2022
b5
approved these changes
Nov 21, 2022
|
thanks @huitseeker! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tool-aided by comby-rust.