Clean up dependencies #474
Conversation
|
Needs to have #475 merged (and rebasing) to pass CI. |
There was a problem hiding this comment.
Thank you for sorting imports! huge pet peve of mine. Can this PR also add a note to DEVELOPERS.md that requests any dependency change keep deps sorted. Seems obvious, but it's important to have something to point to so contributors aren't frustrated with unspoken rules.
I think we should add a new section on dependencies with the following language:
Dependencies
Any crate added to iroh will need to use a license compatible with ours. Any PR that introduces a new crate will require additional review time to audit the crate being introduced, including rationale on why you chose this crate, and what alternatives you considered will speed up the review process.
Crate lists in Cargo.toml files must be kept alphabetically sorted.
flub
force-pushed
the
flub/unused-deps
branch
from
c4af166
to
9dbbf33
Compare
|
@b5 great, added that |
These have been found by `cargo +nightly udeps --all-targets`. Leaving them in does not affect final binaries but does increase compilation time.
Makes it easier to find items and keeps things consistent, e.g. cargo-add will keep lines sorted if they already are sorted.
flub
force-pushed
the
flub/unused-deps
branch
from
9dbbf33
to
286f0bf
Compare
|
PTAL, is rebased on main and developers docs are updated. |
This contains two commits:
This is meant to be committed without squashing, see the commit messages for details.
If the 2nd commit is too controversial I'm happy to remove it.