Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Fix todo by using HashSet::difference #505

Merged
merged 3 commits into from
Nov 17, 2022
Merged

ref: Fix todo by using HashSet::difference #505

merged 3 commits into from
Nov 17, 2022

Conversation

flub
Copy link
Contributor

@flub flub commented Nov 16, 2022

This is probably less efficient though, for this size of hashset. But
it is a higher level abstraction so probably is a bit easier to read.

This is probably less efficient though, for this size of hashset.  But
it is a higher level abstraction so probably is a bit easier to read.
@flub flub requested a review from b5 November 16, 2022 17:17
Copy link
Member

@b5 b5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 thanks!

@b5 b5 merged commit d463a3e into main Nov 17, 2022
@flub flub deleted the flub/svc-diff-todo branch November 22, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants