fix(cli): Respect the --cfg flag #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the --cfg flag to load the configuration file for `iroh`. This does not affect the config files for any of the managed processes like iroh-p2p etc.
flub
commented
Nov 17, 2022
The vec was not really used.
|
Added some test to figure out priority and documented it. Fixed the source order appropriately. Also optimised a vec into a slice, because it seemed a bit odd to have it as a vec. I'd say this is ready for review now. |
b5
reviewed
Nov 17, 2022
| @@ -23,5 +23,8 @@ thiserror = "1.0" | |||
| toml = "0.5.9" | |||
| tracing = "0.1.34" | |||
|
|
|||
| [dev-dependencies] | |||
| testdir = "0.6.0" | |||
There was a problem hiding this comment.
oh yeah, i forgot i did sneak that in. but it was genuinely nice while writing the test...
|
macOS failure is unrelated. merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the --cfg flag to load the configuration file for
iroh.This does not affect the config files for any of the managed
processes like iroh-p2p etc.
This flag was not used before.
Also optimises the make_config call a little by taking a slice
rather than a Vec. And assert and document the priority order.