Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: disable flakey test_dht #516

Merged
merged 1 commit into from
Nov 18, 2022
Merged

tests: disable flakey test_dht #516

merged 1 commit into from
Nov 18, 2022

Conversation

Arqu
Copy link
Collaborator

@Arqu Arqu commented Nov 18, 2022

Really flakey, on new CI runners (m1 mac) it fails consistently.

@Arqu Arqu added the test label Nov 18, 2022
@Arqu Arqu requested a review from ramfox November 18, 2022 13:55
@Arqu Arqu self-assigned this Nov 18, 2022
@Arqu Arqu marked this pull request as ready for review November 18, 2022 13:55
@Arqu Arqu requested a review from b5 November 18, 2022 13:55
Copy link
Member

@b5 b5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make sure it turns non-windows CI green, then good to go

@b5 b5 added this to the v0.1.1 milestone Nov 18, 2022
@Arqu Arqu merged commit cd9fa23 into main Nov 18, 2022
@Arqu Arqu deleted the arqu/flake branch November 18, 2022 14:15
@@ -1445,6 +1445,7 @@ mod tests {
Ok(())
}

#[ignore = "flakey"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there an issue to track this, why is there no todo to review this test and fix it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants