fix: convert v0 -> v1 before base32 conversion #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b5
force-pushed
the
b5/fix_cid_v0_base_urls
branch
from
e63e10a
to
1adc8a5
Compare
iroh-resolver/src/content_loader.rs
Outdated
| .into_v1() | ||
| .unwrap() | ||
| .to_string_of_base(Base::Base32Lower) | ||
| .unwrap(); |
There was a problem hiding this comment.
are you sure this can never error?
iroh-resolver/src/content_loader.rs
Outdated
| let cid_str = cid.to_string_of_base(Base::Base32Lower).unwrap(); | ||
| let cid_str = cid | ||
| .into_v1() | ||
| .unwrap() |
There was a problem hiding this comment.
are you sure this can never error?
There was a problem hiding this comment.
then though shall handle the error :)
dignifiedquire
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes n0-computer/beetle#77
turns out you can't go straight from v0 -> base32 v1, which makes sense, but is irritating. Better than the alternative of silently converting into cidv1 I guess.
Anyway, fixes the gateway