Rename the uds-gateway feature to http-uds-gateway #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
reviewed
Nov 21, 2022
fabricedesre
force-pushed
the
http-uds-feature
branch
from
d39025c
to
368cd93
Compare
|
Can we rebase, lgmt |
fabricedesre
force-pushed
the
http-uds-feature
branch
from
368cd93
to
fdebd71
Compare
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
iroh-onecould not start without a config file, because the gateway rpc_addr was not set. This was due to some confusion about the role of theuds-gatewayfeature iniroh-one/src/config.rs.I can't blame people for being confused since it's not a very good name. This patch tries to improve the situation by:
http-uds-gateway.iroh-oneas iniroh-gateway.With these changes
iroh-onecan start without parameters as expected, and the usage of the configuration file is unchanged.