Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iroh-one): Wire up mem addresses to each other #555

Merged
merged 3 commits into from
Nov 26, 2022

Conversation

flub
Copy link
Contributor

@flub flub commented Nov 24, 2022

This copies the mem-addresses in the config to the bits of config that
are used by the individual services before starting them up. This
should help them talk to each other a little better.


Tested this locally and seems to work, I think?

This copies the mem-addresses in the config to the bits of config that
are used by the individual services before starting them up.  This
should help them talk to each other a little better.
@flub flub requested a review from Arqu November 25, 2022 11:43
@dignifiedquire
Copy link
Contributor

Tested this locally and seems to work, I think?

What did you test?

This might be one of the reasons for n0-computer/beetle#68 because bitswap/p2p can't provide anything if it is not connected to the store.

@flub
Copy link
Contributor Author

flub commented Nov 25, 2022

I tried a simple get via the http interface after clearing all local state

@dignifiedquire
Copy link
Contributor

dignifiedquire commented Nov 25, 2022

resolving content only requires the gateway to be connected to the store, not p2p

@fabricedesre
Copy link
Contributor

Tested this locally and seems to work, I think?

What did you test?

This might be one of the reasons for n0-computer/beetle#68 because bitswap/p2p can't provide anything if it is not connected to the store.

You're spot on! I tried this branch on top of my http-put one and things work as expected! Woohoo!

@flub
Copy link
Contributor Author

flub commented Nov 26, 2022

resolving content only requires the gateway to be connected to the store, not p2p

If the store was deleted first I assumed it needs to come back from the p2p node first to make it into the store? So having deleted the store I'd be more concerned about whether the p2p node can fetch things and serve it without it making it into the store. Is that possible or will it always go via the store?

@dignifiedquire dignifiedquire merged commit ee9677d into main Nov 26, 2022
@dignifiedquire
Copy link
Contributor

@flub I don’t get it 😅 But merging given @fabricedesre confirmation it fixes a bug for him.

We should note that we get a test for this..

@flub
Copy link
Contributor Author

flub commented Nov 26, 2022

We should note that we get a test for this..

yes, I thought that as well. I think this should be a lot more doable once we have the e2e story progressed a bit more.

@dignifiedquire dignifiedquire deleted the flub/one-mem-addrs branch February 20, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants