fixes for issues found during the 0.1.2 release #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dignifiedquire
commented
Nov 28, 2022
•
dignifiedquire
commented
- fix tar and zip release doesn't build beetle#103 which prevents crates depending on the published crates in some cases
- fix hardcoded version information in tests
Arqu
previously approved these changes
Nov 28, 2022
iroh-bitswap/src/metrics.rs
Outdated
| git_version::git_version!( | ||
| prefix = "git:", | ||
| cargo_prefix = "cargo:", | ||
| fallback = "unknown version" |
There was a problem hiding this comment.
for CLI sake I'd prefer fallback to be non space separated or just unknown
dignifiedquire
force-pushed
the
fixes-for-relase
branch
from
6a65a67
to
078d23c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.