feat: add MessageWithChannels trait and derive to remove tedious manual matching
#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
MessageWithChannelstrait that can be implemented on theXxxMessagetypes (the enums where the variants areWithChannels). The trait has afrom_wiremessage that creates theXxxMessagefrom theXxxProtocolplus the quinn streams.The trait can be auto-impl'd via the proc macro. With this, the tedious "match on msg to forward to a local sender" or "match on msg to create the with channels struct" is not needed anymore in all typical cases.
First and foremost have a look at the diffs to the examples.
The first commit aligns the non-iroh quinn rpc to the structure added in #14. Can split out to a separate PR.