refactor: add handle_connection and read_request in rpc module #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2025
rklaehn
approved these changes
Jul 25, 2025
| } | ||
| } | ||
|
|
||
| /// Handles a quic iroh connection with the provided `handler`. |
Collaborator
There was a problem hiding this comment.
This will work not just for iroh quic connections but also for (iroh-)quinn connections outside iroh, right? So maybe the comment is confusing.
Member
Author
|
This was merged as part of #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the non-iroh quinn rpc to the structure added in #14.
This is useful if the high-level
listenfunction is not what you need, but still don't want to write it all yourself.Also adds a check to respect the MAX_MESSAGE_SIZE for request messages as well (previously those were not checked).