feat: varint feature flag #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
Frando/varint-feature
branch
from
3cb4704 to
1bb4dbd
Compare
| pub use quinn_setup_utils::*; | ||
|
|
||
| #[cfg(feature = "rpc")] | ||
| #[cfg(any(feature = "rpc", feature = "varint-util"))] |
There was a problem hiding this comment.
can you add docsrs flags for better docs?
4 tasks
dignifiedquire
approved these changes
Oct 21, 2025
Frando
force-pushed
the
Frando/varint-feature
branch
from
ebeff32 to
417ad94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpcfeature. However iroh-blobs would use those even when the quinn rpc is disabled. So I added a feature flag for this. Maybe the better thing would be to move those out into a varint crate? Dunno. But this is fine too.RequestError::Unreachablevariant ifrpcfeature is disabled.Snafuchokes on empty enums somehow. This was the quick fix to haveiroh_blobsbuild without irpc'srpcfeature. Not sure if there is a better way, would need to investigate what exactly snafu does.