Also reset the MTU when the network paths has changed #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to test this with iroh that it behaves as expected. |
|
confirmed this works, as in, I can see the MTU go back to 1200 when the path changes and the MTUD probes start again to up it, correctly growing the MTU of the direct connection. |
|
The CI failure is not because of this PR, it occurs on the 0.11.x branch as well and is fixed in upstream main branch. I'll update the 0.11.x branch to the latest release and then rebase this PR, which should fix it. In the mean time should not block reviewing this PR. |
The existing mechanism to reset the congestion controller and RTT estimator is insufficient: the MTU should also start anew when the path has changed. This adds this to the same method and renames the functions to make their use clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing mechanism to reset the congestion controller and RTT estimator is insufficient: the MTU should also start anew when the path has changed. This adds this to the same method and renames the functions to make their use clearer.