fix: include off-path challenges in setting challenge lost timer

[divagant-martian]

Description

we need to take into account path challenges for remotes other than received ones when stopping the challenge lost timer

Breaking Changes

n/a

Notes & open questions

n/a

[github-actions]

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/quinn/pr/261/docs/iroh_quinn/

Last updated: 2025-12-16T16:54:00Z

[codecov-commenter]

Codecov Report

❌ Patch coverage is 57.89474% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.48%. Comparing base (706cb2d) to head (5b6efe9).

Files with missing lines	Patch %	Lines
quinn-proto/src/connection/mod.rs	52.94%	8 Missing ⚠️
quinn-proto/src/connection/paths.rs	36.36%	7 Missing ⚠️
quinn-proto/src/connection/timer.rs	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   76.51%   76.48%   -0.04%     
==========================================
  Files          83       83              
  Lines       23167    23203      +36     
==========================================
+ Hits        17727    17746      +19     
- Misses       5440     5457      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[matheus23]

I wonder if it'd be useful to have a function that allows you to set_or_stop a timer, depending on whether you pass it a Some or None.

So this could be used like self.timers.set_or_stop(self.earliest_challenge_considered_lost_instant(), qlog), or sth like that.

[divagant-martian]

I wonder if it'd be useful to have a function that allows you to set_or_stop a timer, depending on whether you pass it a Some or None.

So this could be used like self.timers.set_or_stop(self.earliest_challenge_considered_lost_instant(), qlog), or sth like that.

I like that, I'll add it

[divagant-martian]

@matheus23 added it. It doesn't save too many lines in this case, we could probably use it in some other places as well, but it does reduce the cognitive load so I think it's a good addition

ptal :)